new resource: azurerm_vpn_site

[magodo]

Test Result

💤 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run TestAccAzureRMVpnSite_'

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run TestAccAzureRMVpnSite_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMVpnSite_basic
=== PAUSE TestAccAzureRMVpnSite_basic
=== RUN   TestAccAzureRMVpnSite_complete
=== PAUSE TestAccAzureRMVpnSite_complete
=== RUN   TestAccAzureRMVpnSite_update
=== PAUSE TestAccAzureRMVpnSite_update
=== RUN   TestAccAzureRMVpnSite_requiresImport
=== PAUSE TestAccAzureRMVpnSite_requiresImport
=== CONT  TestAccAzureRMVpnSite_basic
=== CONT  TestAccAzureRMVpnSite_requiresImport
=== CONT  TestAccAzureRMVpnSite_update
=== CONT  TestAccAzureRMVpnSite_complete
--- PASS: TestAccAzureRMVpnSite_basic (202.36s)
--- PASS: TestAccAzureRMVpnSite_complete (202.49s)
--- PASS: TestAccAzureRMVpnSite_requiresImport (214.89s)
--- PASS: TestAccAzureRMVpnSite_update (327.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       327.645s

[katbyte]

Thanks @magodo - i've given this a review and left some comments inline

[katbyte]

if capitals are allowed here could we use some?

Suggested change

	name = "acctest-vwan-%d"
	name = "acctest-VWan-%d"

[magodo]

I have used the mixed case for the name of vpn site resource, but not for these dependent resources, since they should be tested in their own test case. Then once some service changed the naming constraint, we can identify that from the exact test case of that affected resource, which can be easier for us to identify the cause. WDYT?

[katbyte]

We always use acctestRG

Suggested change

	name = "acctest-rg-%d"
	name = "acctestRG-network-%d"

[magodo]

same as above.

[magodo]

@katbyte Thank you for your feedback! I have simplified the schema namings per your suggestions. Please take another look!

💢 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run TestAccAzureRMVpnSite' 
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run TestAccAzureRMVpnSite -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMVpnSite_basic
=== PAUSE TestAccAzureRMVpnSite_basic
=== RUN   TestAccAzureRMVpnSite_complete
=== PAUSE TestAccAzureRMVpnSite_complete
=== RUN   TestAccAzureRMVpnSite_update
=== PAUSE TestAccAzureRMVpnSite_update
=== RUN   TestAccAzureRMVpnSite_requiresImport
=== PAUSE TestAccAzureRMVpnSite_requiresImport
=== CONT  TestAccAzureRMVpnSite_basic
=== CONT  TestAccAzureRMVpnSite_requiresImport
=== CONT  TestAccAzureRMVpnSite_update
=== CONT  TestAccAzureRMVpnSite_complete
--- PASS: TestAccAzureRMVpnSite_requiresImport (200.50s)
--- PASS: TestAccAzureRMVpnSite_basic (222.92s)
--- PASS: TestAccAzureRMVpnSite_complete (229.03s)
--- PASS: TestAccAzureRMVpnSite_update (385.93s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       385.975s

[katbyte]

Thanks @magodo - aside from one comment this LGTM 👍

[ghost]

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!