Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault - supports "contact" block #8937

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Oct 19, 2020

fix #1301

making certificate contact as a standalone resource is pushed back. submit this PR to make it as a embeded field in "key_vault" resource

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a few comments witch i will address now this LGTM! - thanks @njuCZ

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment whilst passing through

@njuCZ
Copy link
Contributor Author

njuCZ commented Oct 27, 2020

@tombuildsstuff could you have a look again? If list is better, I will modify it soon

@ghost ghost removed the waiting-response label Oct 27, 2020
@katbyte katbyte added this to the v2.34.0 milestone Oct 27, 2020
@katbyte katbyte merged commit 65e37e2 into hashicorp:master Oct 27, 2020
katbyte added a commit that referenced this pull request Oct 27, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying Email Contacts for azurerm_key_vault_certificate
3 participants