New resource: azurerm_virtual_hub_security_partner_provider
#8978
Conversation
There was a problem hiding this comment.
Thanks for the pr @neil-yechenwei - overall looks good but i have some questions about resource and schema naming. please see comments left inline
|
|
||
| * `location` - (Required) The Azure Region where the Security Partner Provider should exist. Changing this forces a new resource to be created. | ||
|
|
||
| * `security_provider_type` - (Required) The security provider name. Possible values are `ZScaler`, `IBoss` and `Checkpoint` is allowed. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
Given the docs say name should this be
| * `security_provider_type` - (Required) The security provider name. Possible values are `ZScaler`, `IBoss` and `Checkpoint` is allowed. Changing this forces a new resource to be created. | |
| * `security_provider_name` - (Required) The security provider name. Possible values are `ZScaler`, `IBoss` and `Checkpoint` is allowed. Changing this forces a new resource to be created. |
|
|
||
| * `security_provider_type` - (Required) The security provider name. Possible values are `ZScaler`, `IBoss` and `Checkpoint` is allowed. Changing this forces a new resource to be created. | ||
|
|
||
| * `virtual_hub_id` - (Optional) The ID of the Virtual Hub within which this Security Partner Provider should be created. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
What happens when no vhub is specified?
There was a problem hiding this comment.
The independent security partner provider would be created and it wouldn't be associated to virtual hub.
| %s | ||
|
|
||
| resource "azurerm_security_partner_provider" "test" { | ||
| name = "acctest-spp-%d" |
There was a problem hiding this comment.
Could we ensure capitals work
| name = "acctest-spp-%d" | |
| name = "acctest-SPP-%d" |
| security_provider_type = "ZScaler" | ||
|
|
||
| tags = { | ||
| ENV = "test" |
There was a problem hiding this comment.
and here
| ENV = "test" | |
| ENv = "Test" |
| @@ -102,6 +102,7 @@ func (r Registration) SupportedResources() map[string]*schema.Resource { | |||
| "azurerm_route_filter": resourceArmRouteFilter(), | |||
| "azurerm_route_table": resourceArmRouteTable(), | |||
| "azurerm_route": resourceArmRoute(), | |||
| "azurerm_security_partner_provider": resourceArmSecurityPartnerProvider(), | |||
There was a problem hiding this comment.
I think we should have this be a little more specific? what is this security partner applied to? vhubs? then should this be:
| "azurerm_security_partner_provider": resourceArmSecurityPartnerProvider(), | |
| "azurerm_virtual_hub_security_partner_provider": resourceArmSecurityPartnerProvider(), |
|
|
||
| # azurerm_security_partner_provider | ||
|
|
||
| Manages a Security Partner Provider. |
There was a problem hiding this comment.
Could we elaborate on what a SPP is and what it is applied to?
|
@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks. |
katbyte
changed the title
azurerm_security_partner_providerazurerm_virtual_hub_security_partner_provider
|
This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.36.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
API spec: https://docs.microsoft.com/en-us/rest/api/virtualnetwork/securitypartnerproviders/createorupdate