Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource "azurerm_monitor_smart_detector_alert_rule" #9032

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Oct 27, 2020

notes:

  1. upgrade alertManagement package from "2019-05-05" to "2019-06-01-preview", but the api version of this resource is stable
  2. smart_detector_alert_rule is an alert rule based on smart detector. Currently smart detector are built-in and only supports one kind: "FailureAnomaliesDetector"

image

@ghost ghost added the size/XXL label Oct 27, 2020
@njuCZ njuCZ marked this pull request as ready for review November 9, 2020 02:23
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - i've left some comments inline to address


* `detector_id` - (Required) Specifies the Built-In Smart Detector id that this alert rule will use. Currently possible values are `FailureAnomaliesDetector`.

* `scope` - (Required) Specifies the scopes of this Smart Detector Alert Rule.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we be a bit more clear what type of value/values are epected here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the scope depends on smart detector. Different detector supports different scope


* `ids` - (Required) Specifies the action group ids.

* `custom_email_subject` - (Optional) Specifies the custom email subject.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we expand on what happens when this is left empty?

Suggested change
* `custom_email_subject` - (Optional) Specifies the custom email subject.
* `email_subject` - (Optional) Specifies a custom email subject.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have added more specific explanation for this field.


* `custom_email_subject` - (Optional) Specifies the custom email subject.

* `custom_webhook_payload` - (Optional) A JSON String which Specifies the custom webhook payload.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we expand on what happens when this is left empty?

Suggested change
* `custom_webhook_payload` - (Optional) A JSON String which Specifies the custom webhook payload.
* `webhook_payload` - (Optional) A JSON String which Specifies the custom webhook payload.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have added more specific explanation for this field.

@njuCZ
Copy link
Contributor Author

njuCZ commented Nov 10, 2020

@katbyte thanks for your review. I have updated this PR and left some comments inline, please have a look again

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 👍

@katbyte katbyte merged commit e4a2dff into hashicorp:master Nov 10, 2020
@katbyte katbyte added this to the v2.36.0 milestone Nov 10, 2020
katbyte added a commit that referenced this pull request Nov 10, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants