-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource "azurerm_monitor_smart_detector_alert_rule" #9032
Conversation
1c723ba
to
4c3d7b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @njuCZ - i've left some comments inline to address
azurerm/internal/services/monitor/monitor_smart_detector_alert_rule_resource.go
Show resolved
Hide resolved
azurerm/internal/services/monitor/monitor_smart_detector_alert_rule_resource.go
Show resolved
Hide resolved
azurerm/internal/services/monitor/monitor_smart_detector_alert_rule_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/monitor/monitor_smart_detector_alert_rule_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/monitor/monitor_smart_detector_alert_rule_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/monitor/monitor_smart_detector_alert_rule_resource.go
Outdated
Show resolved
Hide resolved
|
||
* `detector_id` - (Required) Specifies the Built-In Smart Detector id that this alert rule will use. Currently possible values are `FailureAnomaliesDetector`. | ||
|
||
* `scope` - (Required) Specifies the scopes of this Smart Detector Alert Rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we be a bit more clear what type of value/values are epected here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the scope depends on smart detector. Different detector supports different scope
|
||
* `ids` - (Required) Specifies the action group ids. | ||
|
||
* `custom_email_subject` - (Optional) Specifies the custom email subject. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we expand on what happens when this is left empty?
* `custom_email_subject` - (Optional) Specifies the custom email subject. | |
* `email_subject` - (Optional) Specifies a custom email subject. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added more specific explanation for this field.
|
||
* `custom_email_subject` - (Optional) Specifies the custom email subject. | ||
|
||
* `custom_webhook_payload` - (Optional) A JSON String which Specifies the custom webhook payload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we expand on what happens when this is left empty?
* `custom_webhook_payload` - (Optional) A JSON String which Specifies the custom webhook payload. | |
* `webhook_payload` - (Optional) A JSON String which Specifies the custom webhook payload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added more specific explanation for this field.
@katbyte thanks for your review. I have updated this PR and left some comments inline, please have a look again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @njuCZ - LGTM 👍
This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.36.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
notes: