Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise limits for max_count/min_count/node_count of azurerm_kubernetes_cluster_node_pool/azurerm_kubernetes_cluster #9227

Merged
merged 2 commits into from Nov 19, 2020

Conversation

neil-yechenwei
Copy link
Contributor

fixes #9198

--- PASS: TestAccAzureRMKubernetes_all/nodePool (0.00s)
--- PASS: TestAccAzureRMKubernetes_all/nodePool/maxSize (938.57s)
--- PASS: TestAccAzureRMKubernetes_all/scaling (0.00s)
--- PASS: TestAccAzureRMKubernetes_all/scaling/autoScalingEnabledWithMaxCount (675.02s)

…_cluster_node_pool/azurerm_kubernetes_cluster
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@ghost ghost added size/L and removed size/M labels Nov 19, 2020
@tombuildsstuff tombuildsstuff added this to the v2.37.0 milestone Nov 19, 2020
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-11-19 at 17 37 25

@tombuildsstuff tombuildsstuff merged commit 9e4e118 into hashicorp:master Nov 19, 2020
tombuildsstuff added a commit that referenced this pull request Nov 19, 2020
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise limits for azurerm_kubernetes_cluster_node_pool max_count/count parameters
3 participants