Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise limits for azurerm_kubernetes_cluster_node_pool max_count/count parameters #9198

Closed
lorenzo-biava opened this issue Nov 6, 2020 · 3 comments · Fixed by #9227
Closed

Comments

@lorenzo-biava
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AKS now allows for Node Pools of max 1000 nodes (which is also the limit of total nodes across all node pools cluster), provided the singlePlacementGroup flag is disabled in the VMSS.

The limit on the following options should be raised to 1000 (possibly depending on some other flag related to the singlePlacementGroup option?):

  • max_count - (Required) The maximum number of nodes which should exist within this Node Pool. Valid values are between 0 and 100 and must be greater than or equal to min_count.
  • min_count - (Required) The minimum number of nodes which should exist within this Node Pool. Valid values are between 0 and 100 and must be less than or equal to max_count.
  • node_count - (Optional) The initial number of nodes which should exist within this Node Pool. Valid values are between 0 and 100 and must be a value in the range min_count - max_count.

New or Affected Resource(s)

  • azurerm_kubernetes_cluster_node_pool
  • Possibly the azurerm_kubernetes_cluster as well for the default pool

Potential Terraform Configuration

N/A

References

At this time, I can't seem to find any official doc reference to this, except from the VMSS one:

Attaching a picture of the portal showing the updated behavior:
aks-node-pool-size-example

@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@lorenzo-biava
Copy link
Author

@neil-yechenwei thanks for the PR 😃

@ghost
Copy link

ghost commented Dec 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.