Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health_check_path to function_app site_config #9233

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Add health_check_path to function_app site_config #9233

merged 2 commits into from
Nov 12, 2020

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Nov 10, 2020

Fixes #9180

TF_ACC=1 go test -v ./azurerm/internal/services/web/tests/ -timeout=1000m -run TestAccAzureRMFunctionApp_healthCheck
=== RUN   TestAccAzureRMFunctionApp_healthCheck
=== PAUSE TestAccAzureRMFunctionApp_healthCheck
=== CONT  TestAccAzureRMFunctionApp_healthCheck
--- PASS: TestAccAzureRMFunctionApp_healthCheck (186.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web/tests	187.571s

@ghost ghost added the size/XS label Nov 10, 2020
@ghost ghost added size/L documentation and removed size/XS labels Nov 10, 2020
@favoretti favoretti changed the title [WIP]: Add health_check_path to function_app site_config Add health_check_path to function_app site_config Nov 10, 2020
@katbyte katbyte added this to the v2.36.0 milestone Nov 11, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGT< 👍

@jackofallops
Copy link
Member

Tests passing (Failures transient / unrelated)
image

@jackofallops jackofallops merged commit be02263 into hashicorp:master Nov 12, 2020
jackofallops added a commit that referenced this pull request Nov 12, 2020
@favoretti favoretti deleted the favoretti/function_app_health_check branch November 12, 2020 14:29
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "Healthcheck" in Azure Function Apps
4 participants