Update azurerm_windows_virtual_machine - Support patch_mode

[ArcturusZhang]

No description provided.

[ArcturusZhang]

New tests passed:

=== RUN   TestAccWindowsVirtualMachine_otherPatchModeManual
=== PAUSE TestAccWindowsVirtualMachine_otherPatchModeManual
=== CONT  TestAccWindowsVirtualMachine_otherPatchModeManual
--- PASS: TestAccWindowsVirtualMachine_otherPatchModeManual (316.32s)
=== RUN   TestAccWindowsVirtualMachine_otherPatchModeAutomaticByOS
=== PAUSE TestAccWindowsVirtualMachine_otherPatchModeAutomaticByOS
=== CONT  TestAccWindowsVirtualMachine_otherPatchModeAutomaticByOS
--- PASS: TestAccWindowsVirtualMachine_otherPatchModeAutomaticByOS (425.57s)
=== RUN   TestAccWindowsVirtualMachine_otherPatchModeAutomaticByPlatform
=== PAUSE TestAccWindowsVirtualMachine_otherPatchModeAutomaticByPlatform
=== CONT  TestAccWindowsVirtualMachine_otherPatchModeAutomaticByPlatform
--- PASS: TestAccWindowsVirtualMachine_otherPatchModeAutomaticByPlatform (297.50s)
=== RUN   TestAccWindowsVirtualMachine_otherPatchModeUpdate
=== PAUSE TestAccWindowsVirtualMachine_otherPatchModeUpdate
=== CONT  TestAccWindowsVirtualMachine_otherPatchModeUpdate
--- PASS: TestAccWindowsVirtualMachine_otherPatchModeUpdate (692.15s)
PASS

Process finished with exit code 0

[katbyte]

Thanks @ArcturusZhang - overall this looks good but i've left some comments inline that should be addressed

[katbyte]

Could we include a note that this is a preview feature and the command to enable it?

 TestAccWindowsVirtualMachine_otherPatchModeUpdate: testing.go:684: Step 2 error: errors during apply:
        
        Error: updating Windows Virtual Machine "acctestvmlv1eo" (Resource Group "acctestRG-201114233915712563"): compute.VirtualMachinesClient#Update: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="The property 'windowsConfiguration.patchSettings.patchMode' is not valid because the 'Microsoft.Compute/InGuestAutoPatchVMPreview' feature is not enabled for this subscription." Target="windowsConfiguration.patchSettings.patchMode"

[ArcturusZhang]

Oh...yeah I will update the doc to include the enabling process for this. Thanks

[ArcturusZhang]

Hi @katbyte I have add a comment in the schema and a NOTE in the doc on how to enable this preview feature.
Could you also run this command in your testing subscriptions to ensure we could run those tests properly as well?

az feature register -n InGuestAutoPatchVMPreview --namespace Microsoft.Compute

[tombuildsstuff]

@ArcturusZhang is this also applicable for Linux VM's?

[ArcturusZhang]

@ArcturusZhang is this also applicable for Linux VM's?

Well, no, this is only applicable for windows operating systems

[katbyte]

Thanks @ArcturusZhang - LGTM 👍

[ghost]

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

[delampri]

This feature is still in preview, so it failed on every subscription which did not enable it explicity.
please add a feature_flag so it won't fail with the following error:

compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="The property 'windowsConfiguration.patchSettings.patchMode' is not valid because the 'Microsoft.Compute/InGuestAutoPatchVMPreview' feature is not enabled for this subscription." Target="windowsConfiguration.patchSettings.patchMode"

[tombuildsstuff]

@ArcturusZhang based on the comment above, would you mind sending a PR to conditionally set this functionality?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!