Update azurerm_policy_set_definition - Support policy_definition_group
#9259
Conversation
ghost
added
|
Tests all passed! |
There was a problem hiding this comment.
Thanks @ArcturusZhang - overall this looks great, however I've got some questions about some of the property names and we should add a test that sets all the new properties.
azurerm/internal/services/policy/policy_set_definition_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/policy_set_definition_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/policy_set_definition_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/policy_set_definition_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/tests/policy_set_definition_resource_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @ArcturusZhang - just a couple changes to the tests and this should be g2g
azurerm/internal/services/policy/tests/policy_set_definition_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/tests/policy_set_definition_resource_test.go
Outdated
Show resolved
Hide resolved
|
Hi @katbyte I have resolved the comments, please have a look, thank you! |
|
This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.37.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
No description provided.