new resource - "azurerm_synapse_managed_private_endpoint" #9260
Conversation
njuCZ
commented
Nov 11, 2020
njuCZ
commented
|
|
||
| * `target_resource_id` - (Required) The ID of the Private Link Enabled Remote Resource which this Synapse Private Endpoint should be connected to. Changing this forces a new resource to be created. | ||
|
|
||
| * `group_id` - (Required) Specifies the sub resource name which the Synapse Private Endpoint is able to connect to. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
The description says name while the property has _id in it?
There was a problem hiding this comment.
this resource is almost the same with "private_endpoint" resource. In the schema of that resource, group_id is renamed to subresource_names, and I followed the same description here. Should I also keep the same schema name?
There was a problem hiding this comment.
As it stands its confusing so might be best to rename this, if it is subresource_names in the other it would make sense to rename it to taht here
There was a problem hiding this comment.
As its singular subresource_name
| @@ -3,6 +3,7 @@ package client | |||
| import ( | |||
| "fmt" | |||
|
|
|||
| "github.com/Azure/azure-sdk-for-go/services/preview/synapse/2019-06-01-preview/managedvirtualnetwork" | |||
There was a problem hiding this comment.
Is this new package/client only applicable to synapse?
There was a problem hiding this comment.
yes, a new dependency package only applicable to synapse
azurerm/internal/services/synapse/parse/synapse_managed_private_endpoint.go
Outdated
Show resolved
Hide resolved
njuCZ
force-pushed
the
synaspe_private_endpoint
branch
from
b23311c
to
10b42c8
Compare
|
@katbyte thanks for the suggestions, I have updated this PR, and generate IDs for all synapse resource. I have rerun all acctest in this package.
|
njuCZ
force-pushed
the
synaspe_private_endpoint
branch
from
972b871
to
a562704
Compare
|
|
||
| * `target_resource_id` - (Required) The ID of the Private Link Enabled Remote Resource which this Synapse Private Endpoint should be connected to. Changing this forces a new resource to be created. | ||
|
|
||
| * `group_id` - (Required) Specifies the sub resource name which the Synapse Private Endpoint is able to connect to. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
As it stands its confusing so might be best to rename this, if it is subresource_names in the other it would make sense to rename it to taht here
|
|
||
| * `target_resource_id` - (Required) The ID of the Private Link Enabled Remote Resource which this Synapse Private Endpoint should be connected to. Changing this forces a new resource to be created. | ||
|
|
||
| * `group_id` - (Required) Specifies the sub resource name which the Synapse Private Endpoint is able to connect to. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
As its singular subresource_name
|
@katbyte thanks for your suggestion. I have renamed the field "group_id" to "subresource_name", please have a look again when free |
|
This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.41.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
