Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AKS autoscale property for new_pod_scale_up #9291

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

dstrebel
Copy link
Contributor

@dstrebel dstrebel commented Nov 12, 2020

Add AKS Autoscale property for new_pod_scale_up.

Fixes #9008

@marwanad
Copy link

@dstrebel since you're adding this here, do you mind also adding the other September API flags?

image

https://docs.microsoft.com/en-us/azure/aks/cluster-autoscaler#using-the-autoscaler-profile

@marcoboffi
Copy link

I noted that, at moment, creating with TF a nodepool with an auto_scaler_profile, new-pod-scale-up-delay can't be specified but it's not set to default value [10s]. It's set to 0s.
Otherwise if I create nodepool with az-cli command without specifying new-pod-scale-up-delay parameter, this is set correctly to default value [10s].

@marwanad
Copy link

@marcoboffi actually the default should be "0s" - i'll follow up on the doc update.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dstrebel - LGTM 👍

@katbyte katbyte added this to the v2.42.0 milestone Dec 27, 2020
@katbyte katbyte modified the milestones: v2.42.0, v2.43.0 Jan 8, 2021
@tombuildsstuff tombuildsstuff modified the milestones: v2.43.0, v2.44.0 Jan 14, 2021
@tombuildsstuff
Copy link
Member

Pushed a commit to fix the outstanding comments and the tests look good 👍

@tombuildsstuff tombuildsstuff merged commit ce16948 into hashicorp:master Jan 18, 2021
tombuildsstuff added a commit that referenced this pull request Jan 18, 2021
@ghost
Copy link

ghost commented Jan 21, 2021

This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.44.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new-pod-scale-up for autoscaler profile on AKS
6 participants