Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_desktop_application_group wrong MaxLength constraint when checking for presence of existing Virtual Desktop Application Group #9310

Open
timbehh opened this issue Nov 13, 2020 · 3 comments
Labels
bug upstream/microsoft/waiting-on-service-team This label is applicable when waiting on the Microsoft Service Team v/2.x (legacy)

Comments

@timbehh
Copy link

timbehh commented Nov 13, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.13.5
+ provider registry.terraform.io/hashicorp/azurerm v2.36.0

Affected Resource(s)

  • azurerm_virtual_desktop_application_group

Terraform Configuration Files

provider "azurerm" {
  version         = "=2.36.0"
  subscription_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
  features {}
}

resource "azurerm_virtual_desktop_application_group" "desktopapp" {
  name                = "thisnameis39characterslongandshouldwork"
  location            = "eastus"
  resource_group_name = "team-wvdarm"

  type          = "RemoteApp"
  host_pool_id  = "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/team-wvdarm/providers/Microsoft.DesktopVirtualization/hostpools/armpool01"
}

Debug Output

Panic Output

Expected Behaviour

Windows Virtual Desktop Application Group is created

Actual Behaviour

Error: checking for presence of existing Virtual Desktop Application Group "thisnameis39characterslongandshouldwork" (Resource Group "team-wvdarm"): desktopvirtualization.ApplicationGroupsClient#Get: Invalid input: autorest/validation: validation failed: parameter=applicationGroupName constraint=MaxLength value="thisnameis39characterslongandshouldwork" details: value length must be less than or 
equal to 24

  on provider.tf line 7, in resource "azurerm_virtual_desktop_application_group" "desktopapp":
   7: resource "azurerm_virtual_desktop_application_group" "desktopapp" {

The Windows Virtual Desktop Application Group is not created. I had filed a bug before (#8980) that was fixed (#9030). But there seems to be another check for the application group name length when checking if the group is already present. The MaxLength constraint should be 260 characters instead of 24.

Steps to Reproduce

  1. terraform apply

Important Factoids

References

@tombuildsstuff tombuildsstuff added bug upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Nov 13, 2020
@tombuildsstuff
Copy link
Contributor

hi @timbehh

Thanks for opening this issue.

Taking a look through this appears to be an issue in the Azure SDK's validation, rather than Terraform's - so this'd need to be fixed there. @ArcturusZhang would you be able to reach out to the service team to get this fixed?

Thanks!

@ArcturusZhang
Copy link
Contributor

Upstream issue created: Azure/azure-rest-api-specs#11687
And I also assigned the last committer of the swagger, who might take a look and provide a fix for this.

@datr93
Copy link

datr93 commented Nov 16, 2020

@rcskosir rcskosir added upstream/microsoft/waiting-on-service-team This label is applicable when waiting on the Microsoft Service Team and removed upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream/microsoft/waiting-on-service-team This label is applicable when waiting on the Microsoft Service Team v/2.x (legacy)
Projects
None yet
Development

No branches or pull requests

6 participants