Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: adding a shim layer to enable toggling between the Data Plane and Resource Manager API #9314

Merged
merged 18 commits into from Nov 16, 2020

Conversation

tombuildsstuff
Copy link
Member

This PR introduces a shim layer to the Storage resources - which will enable (in the future) users to toggle between the Data Plane API and the Resource Manager API for provisioning certain resources nested within a Storage Account.

Notably at this time, whilst this shim layer is implemented - only one of the Resource Manager wrappers is functionally equivalent (Containers) - as such @yupwei68 will need to liaise with the Storage Team to surface this missing functionality in the Resource Manager API's.

Due to this not being available, at this time I've removed the WIP Resource Manager shims in 35f85897a14fe71c65f8bd751920b6fd274541dd - but once the Storage Team exposes this functionality we can look to re-add this in the future.

Whilst this PR doesn't fix it, this provides a path to solving #2977, once the Storage API's support all of the necessary functionality.

@tombuildsstuff tombuildsstuff added this to the v2.37.0 milestone Nov 13, 2020
@tombuildsstuff tombuildsstuff requested a review from a team November 13, 2020 10:51
@ghost ghost added the size/XXL label Nov 13, 2020
@tombuildsstuff
Copy link
Member Author

Tests look good 👍

@aristosvo
Copy link
Collaborator

Thanks for your amazing work @tombuildsstuff !!

Is it possible to enable the functionality only for the parts which already have an API implemented?

@tombuildsstuff
Copy link
Member Author

@aristosvo we're reaching out to the service team about the missing functionality, bear with us - if there's a fix planned in the not-too-distant future we may as well make this consistent across all resources to ensure this behaviours consistent; if it's a while off we can look to do that, however :)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 79e27af into master Nov 16, 2020
@tombuildsstuff tombuildsstuff deleted the f/storage-shim branch November 16, 2020 19:09
tombuildsstuff added a commit that referenced this pull request Nov 16, 2020
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants