New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: adding a shim layer to enable toggling between the Data Plane and Resource Manager API #9314
Conversation
It also turns out that the Resource Manager API's aren't 100% compatible with the Data Plane resources, so the Resource Manager functionality is unfortunately blocked on the Service Team adding support for the missing functionality.
Tests look good 👍 |
Thanks for your amazing work @tombuildsstuff !! Is it possible to enable the functionality only for the parts which already have an API implemented? |
@aristosvo we're reaching out to the service team about the missing functionality, bear with us - if there's a fix planned in the not-too-distant future we may as well make this consistent across all resources to ensure this behaviours consistent; if it's a while off we can look to do that, however :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR introduces a shim layer to the Storage resources - which will enable (in the future) users to toggle between the Data Plane API and the Resource Manager API for provisioning certain resources nested within a Storage Account.
Notably at this time, whilst this shim layer is implemented - only one of the Resource Manager wrappers is functionally equivalent (Containers) - as such @yupwei68 will need to liaise with the Storage Team to surface this missing functionality in the Resource Manager API's.
Due to this not being available, at this time I've removed the WIP Resource Manager shims in
35f85897a14fe71c65f8bd751920b6fd274541dd
- but once the Storage Team exposes this functionality we can look to re-add this in the future.Whilst this PR doesn't fix it, this provides a path to solving #2977, once the Storage API's support all of the necessary functionality.