Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory - Add support for public_network_enabled for Data Factories #9605

Merged
merged 2 commits into from Jan 8, 2021

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Dec 1, 2020

Fixes #9445

Dependent on Azure/azure-sdk-for-go#13821

@mbfrahry mbfrahry added service/data-factory enhancement upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Dec 1, 2020
@allantargino
Copy link
Contributor

Hi @mbfrahry, thanks for this PR! I will definitely use this feature soon :)

I see it depended on #9445, but seems there is a new version released with the fix.
So now the PR is depended on #9683.

@mbfrahry mbfrahry marked this pull request as ready for review January 8, 2021 19:38
@mbfrahry
Copy link
Member Author

mbfrahry commented Jan 8, 2021

Looking good with the new changes!

--- PASS: TestAccAzureRMDataFactory_publicNetworkDisabled (170.84s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbfrahry mbfrahry merged commit 3dbebfd into master Jan 8, 2021
@mbfrahry mbfrahry deleted the p-data-factory-public-network-access branch January 8, 2021 20:08
mbfrahry added a commit that referenced this pull request Jan 8, 2021
@mbfrahry mbfrahry added this to the v2.43.0 milestone Jan 8, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation enhancement service/data-factory size/L upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for publicNetworkAccess property on resource azurerm_data_factory
3 participants