Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for evenhub dedicated clusters with bigger than 1 capacity #9649

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

alex-goncharov
Copy link
Contributor

@alex-goncharov alex-goncharov commented Dec 3, 2020

This should fix the broken plans (terraform 0.14) with dedicated eventhub clusters which have capacity > 1.

This aims to fix #9650

@ghost ghost added the size/XS label Dec 3, 2020
@alex-goncharov
Copy link
Contributor Author

alex-goncharov commented Dec 3, 2020

Plan with this fix works

$ sed -i 's/Dedicated_1/Dedicated_1X/' ec.tf
$ terraform plan

Error: invalid value for sku_name (SKU name must match /^Dedicated_[1-9][0-9]*$/.)

  on ec.tf line 1, in resource "azurerm_eventhub_cluster" "this":
   1: resource "azurerm_eventhub_cluster" "this" {


$ sed -i 's/Dedicated_1X/Dedicated_1/' ec.tf
$ terraform plan
azurerm_eventhub_cluster.this: Refreshing state... [id=...]

No changes. Infrastructure is up-to-date.

$ terraform version
Terraform v0.14.0
+ provider registry.terraform.io/hashicorp/azurerm v2.38.1

$ gsed -i 's/38\.1/38.0/' provider.tf

$ rm -rf .terraform* && terraform init && terraform version && terraform plan

Initializing the backend...
...

Terraform v0.14.0
+ provider registry.terraform.io/hashicorp/azurerm v2.38.0
azurerm_eventhub_cluster.this: Refreshing state... [id=...]

Error: expected sku_name to be one of [Dedicated_1], got Dedicated_8

  on ec.tf line 1, in resource "azurerm_eventhub_cluster" "this":
   1: resource "azurerm_eventhub_cluster" "this" {

@tombuildsstuff tombuildsstuff added this to the v2.39.0 milestone Dec 3, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit eb14159 into hashicorp:master Dec 4, 2020
katbyte added a commit that referenced this pull request Dec 4, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

This has been released in version 2.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform 0.14 plans are broken for dedicated eventhub clusters with capacity > 1
3 participants