Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_recovery_services_vault: Support for identity block #9689

Merged
merged 2 commits into from
Dec 7, 2020
Merged

azurerm_recovery_services_vault: Support for identity block #9689

merged 2 commits into from
Dec 7, 2020

Conversation

favoretti
Copy link
Collaborator

Fixes #9619

@favoretti
Copy link
Collaborator Author

favoretti commented Dec 4, 2020

$ TF_ACC=1 go test -v ./azurerm/internal/services/recoveryservices/tests -timeout=1000m -run TestRecoveryServicesVault_basicWithIdentity
=== RUN   TestRecoveryServicesVault_basicWithIdentity
=== PAUSE TestRecoveryServicesVault_basicWithIdentity
=== CONT  TestRecoveryServicesVault_basicWithIdentity
--- PASS: TestRecoveryServicesVault_basicWithIdentity (90.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/recoveryservices/tests	91.530s

Unit tests failing seems to be not my doing?

recoveryservices/tests git:(favoretti/recovery_services_vault_identity) $ go test
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/recoveryservices/tests	1.094s

@tombuildsstuff
Copy link
Member

@favoretti apologies, that's related to a re-generation needing re-running (we're still working through hooking that up, so there's no GHA to catch that until it's all the way through)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte added this to the v2.40.0 milestone Dec 7, 2020
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-12-07 at 11 49 07

@tombuildsstuff tombuildsstuff merged commit a3b7170 into hashicorp:master Dec 7, 2020
tombuildsstuff added a commit that referenced this pull request Dec 7, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add identity MSI SystemAssigned to azurerm_recovery_services_vault
3 participants