Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamanalytics: generating Resource ID Formatters/Parsers for Stream Input #9735

Merged
merged 9 commits into from
Dec 8, 2020

Conversation

tombuildsstuff
Copy link
Member

This PR adds a Resource ID Formatter/Parser for Stream Input - used through the following resources:

  • azurerm_stream_analytics_reference_input_blob
  • azurerm_stream_analytics_stream_input_blob
  • azurerm_stream_analytics_stream_input_iothub
  • azurerm_stream_analytics_stream_input_eventhub

and also adds Enhanced Import Validation to those resources. I'll work through the rest of the package in the morning.

@tombuildsstuff tombuildsstuff added this to the v2.40.0 milestone Dec 7, 2020
@tombuildsstuff tombuildsstuff requested a review from a team December 7, 2020 18:12
@ghost ghost added the size/XL label Dec 7, 2020
@tombuildsstuff tombuildsstuff marked this pull request as draft December 7, 2020 18:56
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff marked this pull request as ready for review December 8, 2020 10:49
@tombuildsstuff
Copy link
Member Author

Tests pass:

Screenshot 2020-12-08 at 17 59 18

@tombuildsstuff tombuildsstuff merged commit a95a1c3 into master Dec 8, 2020
@tombuildsstuff tombuildsstuff deleted the r/resource-ids/stream-analytics branch December 8, 2020 16:59
tombuildsstuff added a commit that referenced this pull request Dec 8, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants