Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase limit from 1 to 10 for application_security_group in network_security_rule #9884

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

mybayern1974
Copy link
Collaborator

The Azure service team has increased the number of allowed ASGs in an NSR from 1 to 10. I've tested it locally and it worked: the service could accept up to 10 and reported errors when accepting 10+.

Below is the corresponding test case pass:

=== RUN   TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
=== PAUSE TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
=== CONT  TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups
--- PASS: TestAccAzureRMNetworkSecurityRule_applicationSecurityGroups (173.47s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@katbyte katbyte merged commit 6045d90 into hashicorp:master Dec 21, 2020
katbyte added a commit that referenced this pull request Dec 21, 2020
@ghost
Copy link

ghost commented Jan 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants