Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_linked_service - Add validation for resource ID type #9932

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

WodansSon
Copy link
Collaborator

Adding validation for Resource ID type based on field:

Field Name Required Resource ID type
resource_id Microsoft.Automation/automationAccounts
read_access_id Microsoft.Automation/automationAccounts
write_access_id Microsoft.OperationalInsights/clusters

@ghost ghost added the size/M label Dec 18, 2020

if d.HasChange("write_access_id") {
if writeAccessID := d.Get("write_access_id").(string); writeAccessID != "" {
if !validate.IsLogAnalyticsClusterID(writeAccessID) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a generated validator for this one in loganalytics validate, maybe use that one instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point... I'll update my logic to use the generated validator rather than my own.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WodansSon
Copy link
Collaborator Author

Hit Cluster quota limit for the subscription, all other tests passed:

image

@WodansSon WodansSon merged commit 7c28e4f into master Dec 18, 2020
@WodansSon WodansSon deleted the e-log-analytics-linked-services-checks branch December 18, 2020 06:33
WodansSon added a commit that referenced this pull request Dec 18, 2020
return false
}

return true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WodansSon rather than including an ID from outside of it's package, can we generate the "AutomationAccountId" in the automation package and reference that's validation function here, rather than adding this in? Else we'll end up with duplicates all over the place

Copy link
Collaborator Author

@WodansSon WodansSon Dec 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries... opened #9950 to address that issue...

@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants