Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_linked_service - Update validation to use generated validate functions #9950

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

WodansSon
Copy link
Collaborator

Addressing comment by @tombuildsstuff on PR #9932:

@WodansSon rather than including an ID from outside of it's package, can we generate the "AutomationAccountId" in the automation package and reference that's validation function here, rather than adding this in? Else we'll end up with duplicates all over the place

  • Added generated code to Automation resource (parse, validate)
  • Update logic in log analytics linked service to use generated validation code
  • Removed manually written validation code from log analytics linked service

@WodansSon
Copy link
Collaborator Author

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WodansSon WodansSon merged commit c158de3 into master Dec 20, 2020
@WodansSon WodansSon deleted the e-automation-validation branch December 20, 2020 02:40
WodansSon added a commit that referenced this pull request Dec 20, 2020
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants