Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_media_content_key_policy #9971

Merged
merged 18 commits into from
Jan 21, 2021
Merged

New resource: azurerm_media_content_key_policy #9971

merged 18 commits into from
Jan 21, 2021

Conversation

jcanizalez
Copy link
Contributor

Hi there introducing the support for new resource azurerm_media_content_key_policy. This PR resolves #9863

Checked:

  • Update Documentation
  • Add new Acceptance Test and verified that the tests pass successfully
  • Check linting

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jcanizalez

Thanks for this PR - apologies for the delayed review here!

Taking a look through on the whole this is looking pretty good, if we can fix up the comments then we should be able to take another look and get this merged :)

Thanks!

@jcanizalez
Copy link
Contributor Author

hey @tombuildsstuff thank you for your review. I applied your suggestions so you can take a look again.
Thanks

@ghost ghost removed the waiting-response label Jan 16, 2021
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jcanizalez

Thanks for pushing those changes - having taken a look through the commits I've spotted one thing but this otherwise looks good to me 👍

Thanks!

@jcanizalez
Copy link
Contributor Author

hi @tombuildsstuff I applied you suggestion, so you can check it again

@ghost ghost removed the waiting-response label Jan 18, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - LGTM 💯

@katbyte katbyte merged commit f0ae466 into hashicorp:master Jan 21, 2021
katbyte added a commit that referenced this pull request Jan 21, 2021
@ghost
Copy link

ghost commented Jan 21, 2021

This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.44.0"
}
# ... other configuration ...

@jcanizalez jcanizalez deleted the azurerm_media_content_key_policy branch January 25, 2021 19:53
@ghost
Copy link

ghost commented Feb 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Content Key Policy in Azure Media Services Account
3 participants