Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - parse oms log_analytics_workspace_id to ensure correct casing #9976

Merged
merged 1 commit into from
Jan 5, 2021
Merged

azurerm_kubernetes_cluster - parse oms log_analytics_workspace_id to ensure correct casing #9976

merged 1 commit into from
Jan 5, 2021

Conversation

favoretti
Copy link
Collaborator

Instead of changing casing back as #9967 proposes, parse the ID in oms_addon by using the same parsers, to fix #9151

@blaw2422
Copy link

this fixes my current use-case. Is the idea behind the parser that it should be used any time a reference is made to this resource?

@favoretti
Copy link
Collaborator Author

favoretti commented Dec 22, 2020

That's my understanding. Note that I'm neither HC nor MSFT, so my understanding doesn't matter much :)

@katbyte katbyte added this to the v2.42.0 milestone Dec 27, 2020
@katbyte katbyte changed the title Parse LAW ID through LA parsers in oms_addon azurerm_kubernetes_cluster - parse oms log_analytics_workspace_id to ensure correct casing Dec 27, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte merged commit bcba444 into hashicorp:master Jan 5, 2021
katbyte added a commit that referenced this pull request Jan 5, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_kubernetes_cluster incorrect diff due to casing on addon_profile.oms_agent.log_analytics_workspace_id
3 participants