Add support for node pool autoscaling #157
Conversation
| @@ -129,10 +180,70 @@ func resourceContainerNodePoolRead(d *schema.ResourceData, meta interface{}) err | |||
|
|
|||
| d.Set("name", nodePool.Name) | |||
| d.Set("initial_node_count", nodePool.InitialNodeCount) | |||
| if nodePool.Autoscaling != nil && nodePool.Autoscaling.Enabled { | |||
There was a problem hiding this comment.
How do we detect if autoscaling has been turned on out of band and needs to be switched back on?
There was a problem hiding this comment.
Ah, that's a good point.
I went ahead and checked what the cloud console does- when you turn autoscaling off and then back on, you lose the min/max node count you had originally set. Based on that, I removed the enabled attribute so we can easily detect out-of-band changes (this way we don't need to differentiate between set to false and not set at all, although in retrospect maybe a DiffSuppressFn on the autoscaling attribute would work? not sure). Let me know what you think.
* add node pool autoscaling * docs for node pool autoscaling * remove enabled attribute * remove enabled from docs
* add node pool autoscaling * docs for node pool autoscaling * remove enabled attribute * remove enabled from docs
* add node pool autoscaling * docs for node pool autoscaling * remove enabled attribute * remove enabled from docs
Add to state before we send the create call.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #44.
This is essentially the same code as hashicorp/terraform#12779, except I added the
enabledattribute and support for update.