Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating google_container_cluster.monitoring_service #598

Merged
merged 8 commits into from
Oct 20, 2017

Conversation

danawillow
Copy link
Contributor

Fixes #308.
Part of #474.

Original PR is #309, this update also adds tests.

@danawillow
Copy link
Contributor Author

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_withMonitoring'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withMonitoring -timeout 120m
=== RUN   TestAccContainerCluster_withMonitoring
--- PASS: TestAccContainerCluster_withMonitoring (594.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	594.933s

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danawillow danawillow merged commit 62eb5ce into hashicorp:master Oct 20, 2017
@danawillow danawillow deleted the pr-309 branch October 20, 2017 16:46
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
<!-- This change is generated by MagicModules. -->
Original Author: @chrisst
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to change monitoring_service on google_container_cluster without recreation
4 participants