Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: can't set up a www -> no-www redirect now, used to work in 3.25.0 #6695

Closed
hallvors opened this issue Jun 25, 2020 · 3 comments · Fixed by GoogleCloudPlatform/magic-modules#3722, #6721 or hashicorp/terraform-provider-google-beta#2247
Assignees
Labels

Comments

@hallvors
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.27

  • provider.google v3.27.0

Affected Resource(s)

  • google_compute_url_map

Terraform Configuration Files

This is an extract from a larger file:

resource "google_compute_url_map" "default" {
  name        = "test-staging-loadbalancer-urlmap"
  description = "test load balancer (URL map). Managed by Terraform."

  project         = test
  default_service = google_compute_backend_service.public.self_link

  host_rule {
    hosts        = [var.domain_admin]
    path_matcher = "admin"
  }

  path_matcher {
    name            = "admin"
    default_service = google_compute_backend_service.admin.self_link
  }

  host_rule {
    description  = "remove www. prefixes"
    hosts        = ["www.${var.domain_public}"]
    path_matcher = "public-nowww"
  }

  path_matcher {
    name = "public-nowww"
    default_url_redirect {
      host_redirect = var.domain_public
      strip_query   = false
    }
  }
}

Expected Behavior

www.* to no-www redirect, like one is still allowed to configure manually in the console.

Actual Behavior

Running this in 3.25.0 works fine, running it with 3.27.0 causes an error:
Error: "path_matcher.1.default_url_redirect": conflicts with default_service

I think this may be a regression caused by #6547

Also, I'm not the only person who ran into this problem: https://stackoverflow.com/questions/62469495/how-to-add-host-redirect-from-secondary-to-primary-domain-using-terraform-and-go

I understand this change my be on purpose and perhaps the config should have different URL maps set up instead of adding these rules to a single URL map. If so, documentation for a breaking change on how to fix it would be appreciated.

References

@ghost ghost added bug labels Jun 25, 2020
@edwardmedia edwardmedia self-assigned this Jun 25, 2020
@edwardmedia
Copy link
Contributor

I do see behavior changes

@c2thorn
Copy link
Collaborator

c2thorn commented Jun 30, 2020

@hallvors thanks for pointing this out! It was unintended behavior, and should be resolved in the next patch.

@ghost
Copy link

ghost commented Jul 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.