Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer access control #6392

Conversation

modular-magician
Copy link
Collaborator

Fixes: #6106

Release Note Template for Downstream PRs (will be copied)

composer: Added support for `google_composer_environment` `web_server_network_access_control` for private environments (Beta only)
composer: Added support for `google_composer_environment` `config.private_environment_config.cloud_sql_ipv4_cidr_block`
composer: Added support for `google_composer_environment` `config.private_environment_config.web_server_ipv4_cidr_block`

Derived from GoogleCloudPlatform/magic-modules#3503

* Create works, update needs help

* non-plural name for set items

* Add sql and web server ip cidr blocks

* Test passes

* Remove schema from ga version, fix lint erro

* Add note to composer docs linking to private environment setup

* Computed web server access as it has default values set by API. Ignore during import tests

* Add computed to new cidr blocks as they get default values based on the region they exist in

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit fcd9175 into hashicorp:master May 15, 2020
@ghost
Copy link

ghost commented Jun 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer environment fields are missing, one is required to create private environments
1 participant