Skip to content
This repository has been archived by the owner on Nov 14, 2020. It is now read-only.

Use ParseTolerant to allow Major.Minor version numbers that PG 10 uses #31

Merged
merged 1 commit into from
May 17, 2018

Conversation

tomelliff
Copy link
Contributor

Fixes #30

@tomelliff
Copy link
Contributor Author

tomelliff commented Mar 2, 2018

I've ran acceptance tests against a 9.6 Postgres Docker container and a 10.2 Postgres Docker container.

It feels like we should be able to run the acceptance tests in Travis on every PR though because there's no real cost to them unlike the AWS provider acceptance tests (where I have more experience) as we can just run things against a Travis hosted Postgres Docker container.

Would you have any issues with me raising another pull request to add these acceptance tests automatically to the pipeline and some steps about how to test locally?

Edit: Apparently Travis CI doesn't yet offer Postgres 10 as a service. Circle CI has a container available for it though so could switch to that? Or could use some of the hacky workarounds in that Travis thread to get it working on Travis instead?

@smelchior
Copy link

It would be great if this could be merged, i really want to use the provider with psql 10!

@meangrape
Copy link

It would be great to see this merged.

@cliveza
Copy link

cliveza commented May 17, 2018

Merge, do it, you know you want to.

@sean- sean- merged commit 1d9aff2 into hashicorp:master May 17, 2018
@sean-
Copy link
Contributor

sean- commented May 17, 2018

Make it so.

@smelchior
Copy link

Thanks for merging this! When will there be a new release, so i can use the fixed version of the plugin?

@rsheldon
Copy link

Running into this too - can you please release this?

@captn3m0
Copy link

Please release this.

@nomihtaa
Copy link

nomihtaa commented Jul 4, 2018

Voting for this one too, one of our backlog ticket is geting lonely.

tombuildsstuff added a commit that referenced this pull request Jul 6, 2018
@sean-
Copy link
Contributor

sean- commented Jul 7, 2018

This was released yesterday as 0.1.2 (thank you @tombuildsstuff!). Thanks for your patience everyone. Cheers.

@sean- sean- self-assigned this Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants