Add gcp auth role extras #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
There was a problem hiding this comment.
Hi @petems! Thanks for working on this!
I suspect these three fields also need to be added to the gcpAuthResourceRead method too.
Also, it would be great to get test coverage on these fields. A simple way to do that would be to add the three fields just below here, and to hard-code in some real sample values.
petems
force-pushed
the
add_gcp_auth_role_extras
branch
from
9d0e6d5
to
8e57629
Compare
|
@tyrannosaurus-becks Good point, I added the new fields to I added a new test for the new hardcoded values, but I don't think I'm actually checking that those values are set... can you help me with that test if you have some time? 😄 |
* Extra `gce` role specific configuration
petems
force-pushed
the
add_gcp_auth_role_extras
branch
2 times, most recently
from
72bb754
to
d37142e
Compare
petems
force-pushed
the
add_gcp_auth_role_extras
branch
from
d37142e
to
b47f958
Compare
|
Closing in favour of #227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few extra fields for GCE role speficic config