-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gcp auth role extras #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @petems! Thanks for working on this!
I suspect these three fields also need to be added to the gcpAuthResourceRead
method too.
Also, it would be great to get test coverage on these fields. A simple way to do that would be to add the three fields just below here, and to hard-code in some real sample values.
9d0e6d5
to
8e57629
Compare
@tyrannosaurus-becks Good point, I added the new fields to I added a new test for the new hardcoded values, but I don't think I'm actually checking that those values are set... can you help me with that test if you have some time? 😄 |
* Extra `gce` role specific configuration
72bb754
to
d37142e
Compare
d37142e
to
b47f958
Compare
Closing in favour of #227 |
Adding a few extra fields for GCE role speficic config