d/network: Remove vCenter requirement #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resource has always functioned correctly on ESXi, and will be required to work with virtual machines going forward, so it's important it works on both ESXi and vCenter. Specifically tested this on ESXi to make sure. Also added skips for all the DVS related tests in this data source so that the host/standard port group example is the only one that runs when conducting ESXi tests.
vancluever
force-pushed
the
b-net-data-remove-vcenter-gate
branch
from
631986e
to
7b75e5d
Compare
|
Just merging this in now. All this does is remove a minor restriction and does not change functionality. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resource has always functioned correctly on ESXi, and will be
required to work with virtual machines going forward, so it's important
it works on both ESXi and vCenter.
Specifically tested this on ESXi to make sure. Also added skips for all
the DVS related tests in this data source so that the host/standard port
group example is the only one that runs when conducting ESXi tests.