helper/viapi: Fix version comparison logic #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version comparison logic was not sound across minor and patch versions. The new logic just bit-shifts major and minor so that a nice clean comparable integer. I'd imagine this will be fine, as I've never seen VMware put out any sort of release with a version anywhere close to the 8-bit space we give each version particle now. Fixes #265.
vancluever
changed the title
|
Thanks @mbfrahry! Merging now |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version comparison logic was not sound across minor and patch versions.
The new logic just bit-shifts major and minor so that a nice clean
comparable integer. I'd imagine this will be fine, as I've never seen
VMware put out any sort of release with a version anywhere close to the
8-bit space we give each version particle now.
Fixes #265.