fix: Field 'comment' not found in the schema (#214)

* fix: Field 'comment' not found in the schema Fixes #213 * test: Fix broken tests
terraform-routeros · May 17, 2023 · 01a7f10 · 01a7f10
1 parent c519f27
commit 01a7f10
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/routeros/datasource_ip_addresses.go b/routeros/datasource_ip_addresses.go
@@ -32,6 +32,10 @@ func DatasourceIPAddresses() *schema.Resource {
 							Type:     schema.TypeString,
 							Computed: true,
 						},
+						KeyComment: {
+							Type:     schema.TypeString,
+							Computed: true,
+						},
 						"disabled": {
 							Type:     schema.TypeBool,
 							Computed: true,

diff --git a/routeros/datasource_ip_routes.go b/routeros/datasource_ip_routes.go
@@ -2,6 +2,7 @@ package routeros
 
 import (
 	"context"
+
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
@@ -31,6 +32,10 @@ func DatasourceIPRoutes() *schema.Resource {
 							Type:     schema.TypeBool,
 							Computed: true,
 						},
+						KeyComment: {
+							Type:     schema.TypeString,
+							Computed: true,
+						},
 						"connect": {
 							Type:     schema.TypeBool,
 							Computed: true,

diff --git a/routeros/resource_capsman_configuration_test.go b/routeros/resource_capsman_configuration_test.go
@@ -31,6 +31,8 @@ func TestAccCapsManConfigurationTest_basic(t *testing.T) {
 					{
 						Config: testAccCapsManConfigurationConfig(1),
 						Check: resource.ComposeTestCheckFunc(
+							resource.TestCheckResourceAttr("routeros_capsman_configuration.test_configuration_2",
+								"name", "test_configuration_2"),
 							resource.TestCheckResourceAttrSet("routeros_capsman_configuration.test_configuration_2",
 								"channel.config"),
 							resource.TestCheckResourceAttrSet("routeros_capsman_configuration.test_configuration_2",
@@ -103,7 +105,7 @@ resource "routeros_capsman_security" "test_security" {
 }
 
 resource "routeros_capsman_configuration" "test_configuration_2" {
-	name = "test_configuration"
+	name = "test_configuration_2"
 
 	channel = {
 	  config                = "${routeros_capsman_channel.test_channel.name}"