Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interface child items had incorrect reference #100

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

gfenn-newbury
Copy link
Collaborator

No description provided.

@vaerh
Copy link
Collaborator

vaerh commented Feb 15, 2023

I just wanted to discuss the different resource naming in our versions. I have shortened some of the name. Maybe it makes sense for these resources to make a double naming?
https://github.com/GNewbury1/terraform-provider-routeros/blob/1ebca01793f8d423fbcc2fee33ae2de5dbc98a08/routeros/provider.go#L78-L85

@gfenn-newbury
Copy link
Collaborator Author

I just wanted to discuss the different resource naming in our versions. I have shortened some of the name. Maybe it makes sense for these resources to make a double naming?

https://github.com/GNewbury1/terraform-provider-routeros/blob/1ebca01793f8d423fbcc2fee33ae2de5dbc98a08/routeros/provider.go#L78-L85

Actually yeah, that's a good idea. Gimme a sec and I'll push the change for you to review

@gfenn-newbury
Copy link
Collaborator Author

How does that look? Added some comments so we don't forget why we did this :P

Copy link
Collaborator

@vaerh vaerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what is needed!

@gfenn-newbury gfenn-newbury merged commit aaeb4fc into main Feb 15, 2023
@gfenn-newbury gfenn-newbury deleted the fix/interface_child_items branch February 15, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants