WIP - implementation of routeos_interface_ethernet #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, I'm always happy to have good, clean code. |
vaerh
reviewed
Sep 18, 2023
docs/resources/interface_ethernet.md
Outdated
There was a problem hiding this comment.
Documentation is automatically generated with each release. For this reason, there is no need to generate documentation in PR. But it is necessary to fill in the resource example and export example files.
|
@jlpedrosa Please check the current changes with yourself. The tests should run without warnings. |
…API/Rest) get the running values.
…rovider-routeros into interface_ethernet
|
@vaerh let me know if you want any changes, happy to do them. Also, I ran the test locally, but actions is not enabled for this PR (authorization), so I'm not sure if it's going to work in all CI scenarios. |
vaerh
approved these changes
Sep 19, 2023
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was wondering if you'd be open for PRs? it is related to the issue I opened ( #255 ). I just wanted to drop a WIP to grock if you are interested in contributions and/or if it's more or less where your head is at.
There are a lot of properties pending, and the tests. Just to see what is your opinion.