feat: Update some properties to support multiple values #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt multiple values
…teros_interface_dot1x_server` to support multiple values
…an` to support multiple values
…idge_vlan` to ignore values order
…o support multiple values
vaerh
approved these changes
Jul 1, 2024
|
Thanks for migrating the state for |
dokmic
force-pushed
the
feature/multiple-values
branch
5 times, most recently
from
9fdea29
to
27c8588
Compare
|
@vaerh, thanks for the review 👍 I've fixed all the failing tests, and it can be merged safely now. |
|
🎉 This PR is included in version 1.55.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly about fixing resource schemas to support multiple values instead of comma-separated string values:
routeros_system_loggingandrouteros_interface_bridge_vlan, types have been corrected to ignore values order.routeros_radius,routeros_dns,routeros_ip_dhcp_server_network,routeros_interface_dot1x_client,routeros_interface_dot1x_server,routeros_interface_bridge_vlan, androuteros_capsman_channel, types have been updated to support multiple values.routeros_snmp_community, a state migrator has been added to fix a regression introduced in routeros_snmp_community Addresses Doesn't Accept Multiple Addresses #495.