Update docs to match with TS typings #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
approved these changes
May 13, 2020
There was a problem hiding this comment.
DefinitelyTyped/DefinitelyTyped#44680 ... I fixed a few typos in the docs.
awesome. thank you for tackling the typings and for these fixes!
the generated docs are missing a few functions: positionToMercator, toGeographic, isConvex...
off the top of my head, i'm not sure. i'll see if i can figure it out sometime soon.
i'm also planning on looking at Esri/terraformer#321 sometime soon to see if i can help you ditch that other dependency of yours altogether.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jgravois! I'm working on the TS typings for @terraformer/spatial, please see this DefinitelyTyped PR DefinitelyTyped/DefinitelyTyped#44680.
I fixed a few typos in the docs. Most significant is missing one level of nested array in
convexHullresult andpolygonContainsPointargument.Also, the generated docs is missing a few functions:
positionToMercator,toGeographic,isConvex, even though they are documented. Also, exported constantsMercatorCRS,GeographicCRS. I couldn't figure out yet why, maybe you have an idea?