SSH2: present a less cryptic error message when channel isn't open

terrafrost · Feb 7, 2023 · 4a79a24 · 4a79a24
1 parent 2487192
commit 4a79a24
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/phpseclib/Net/SSH2.php b/phpseclib/Net/SSH2.php
@@ -4323,6 +4323,11 @@ protected function send_channel_packet($client_channel, $data)
      */
     private function close_channel($client_channel, $want_reply = false)
     {
+        if (!isset($this->server_channels[$client_channel])) {
+            $this->disconnect_helper(NET_SSH2_DISCONNECT_CONNECTION_LOST);
+            throw new \RuntimeException('Unable to close a channel that was never opened');
+        }
+
         // see http://tools.ietf.org/html/rfc4254#section-5.3
 
         $this->send_binary_packet(pack('CN', NET_SSH2_MSG_CHANNEL_EOF, $this->server_channels[$client_channel]));