[IMPL] HelloSmoke #122
Merged
[IMPL] HelloSmoke #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngmarBitter
force-pushed
the
Smoke
branch
2 times, most recently
from
f250e9b
to
eec966a
Compare
IngmarBitter
force-pushed
the
Smoke
branch
2 times, most recently
from
33994a0
to
02ab124
Compare
Is a clone of HelloTexture3D. Then added ability to allocate Textures with specified texel format
| const uint TexturePixels = TextureDz * TextureDepth; | ||
| const uint TextureSize = TexturePixels * 4; | ||
|
|
||
| var texture3D = graphicsContext.Device.MemoryAllocator.CreateTexture(GraphicsTextureKind.ThreeDimensional, GraphicsResourceCpuAccess.None |
There was a problem hiding this comment.
Same feedback as on #126 (comment)
There was a problem hiding this comment.
I made a local variable before the call and make the call one line with the variable at the end of the line.
| float scale = 2 * MathF.Abs(0.5f - radius); | ||
| // random value scaled by the above | ||
| float rand = (float)random.NextDouble(); | ||
| if (!isQuickAndDirty && rand < 0.99) |
There was a problem hiding this comment.
Suggested change
| if (!isQuickAndDirty && rand < 0.99) | |
| if (!isQuickAndDirty && (rand < 0.99)) |
There was a problem hiding this comment.
and with { ... } after the if, as in the comment above I assume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample that uses a 3d Texture of float values which are used by the shaders to create an impression of smoke. Introduces over the prior samples specifying a custom texel type and converting in the shaders from single value intensities to RGB.