Added serialization / deserialization ability for AppScreen

[Starksoft]

Hi!

I'm using Cicerone 5.0.0 and in this version serialization worked fine. After update to 6.6.0 I found, that serialization doesn't work. Serialization saw broken by AppScreen and Creator<A, R>.

Also naming of functions in Screens object starts with upper-case letter and lint warns us about it.

I suggest to change functions to val and user UPPER-case naming

[terrakok]

First of all, In case when you have to pass some arguments to new screen you should use function with arguments. So I like consistency and I use functions for all my screens.

About 'serializable'. Why do you need it? Basically using serializable interface is bad idea. Nonetheless, if you want it you have to serialize data but not screen instance. Because Screen is factory for fragment (or activity).

[Starksoft]

First of all, In case when you have to pass some arguments to new screen you should use function with arguments. So I like consistency and I use functions for all my screens.

It's, Ok, but in functions first letter must be lower-case.

About 'serializable'. Why do you need it? Basically using serializable interface is bad idea. Nonetheless, if you want it you have to serialize data but not screen instance. Because Screen is factory for fragment (or activity).

In my app I have two Activities: MainActivity and CommonActivity.
When I need to open Fragment in other Activity, I need to pass Screen instance (with argument or not) through Intent, for that case I need to Serialize Screen. When Cicerone was written in Java, I can create my own child-class and implement Serializable interface. But when You migrate to Kotlin You add a Creator interface and Serialization now is broken.
If You don't want to add Serialization to base classes, we can create a SerializableAppScreen.

[terrakok]

in functions first letter must be lower-case

Do you know about Compose? 😄

For your case i recommend you pass not serialized screen but serialized parameters for screen. And on other activity side select screen by received parameters

[Starksoft]

Cicerone is not the Compose. And it doesn't use DSL.

No, we need to pass serialized Screen and we don't want to implement odd logic with selection of screen by screen args.
We'll continue to use forked Cicerone.

[terrakok]

In my opinion, description of screens is simple DSL. Cicerone doesn't force to use upper case for first letter. You can do it as you want 😉

You can use own fork for your cases with serialization of screens.
I hope I showed that Cicerone doesn't stop you for using multi activity approach but starting new app development I would recommend you Single activity approach

[Starksoft]

Our project is a bit larger, than example 🙂

In our project we can't use single activity in case of different themes and other platform staff, like other processes

[terrakok]

I think You are wrong if you think that Single activity approach is only for small applications.
e.g. Uber, Telegram and lots of other big and popular applications are written in this approach.

But it is offtop for this topic :)
If you interested I leave here this link: https://www.youtube.com/watch?v=wcdqoTubPrU

[terrakok]

82256a9

Now, FragmentScreen and ActivityScreen are interfaces so you can implement them with Serializable