chore(tmc): disable log syncing for non-utf8 output.

Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>

cloud/log_syncer.go

@@ -8,6 +8,7 @@ import (
 	"io"
 	"sync"
 	"time"
+	"unicode/utf8"
 
 	"github.com/rs/zerolog/log"
 	"github.com/terramate-io/terramate/errors"
@@ -68,6 +69,7 @@ func (s *LogSyncer) NewBuffer(channel LogChannel, out io.Writer) io.Writer {
 	go func() {
 		defer s.wg.Done()
 		linenum := int64(1)
+		syncDisabled := false
 
 		var pending []byte
 		errs := errors.L()
@@ -86,6 +88,16 @@ func (s *LogSyncer) NewBuffer(channel LogChannel, out io.Writer) io.Writer {
 					errs.Append(errors.E(err, "writing to terminal"))
 				}
 
+				if syncDisabled {
+					continue
+				}
+
+				if !utf8.Valid(line) {
+					syncDisabled = true
+					errs.Append(errors.E("skipping sync of non-utf8 (%s) output", channel.String()))
+					continue
+				}
+
 				t := time.Now().UTC()
 				s.in <- &DeploymentLog{
 					Channel:   channel,

cloud/log_syncer_test.go

@@ -361,6 +361,33 @@ func TestCloudLogSyncer(t *testing.T) {
 				},
 			},
 		},
+		{
+			name: "disable sync in case non-utf8 output is detected",
+			writes: []write{
+				{channel: cloud.StdoutLogChannel, data: []byte("valid\n")},
+				{channel: cloud.StdoutLogChannel, data: []byte{0x80, 1, 2, 3, 4, '\n'}},
+				{channel: cloud.StdoutLogChannel, data: []byte("another valid")},
+			},
+			want: want{
+				output: map[cloud.LogChannel][]byte{
+					cloud.StdoutLogChannel: {
+						'v', 'a', 'l', 'i', 'd', '\n',
+						0x80, 1, 2, 3, 4, '\n',
+						'a', 'n', 'o', 't', 'h', 'e', 'r', ' ', 'v', 'a', 'l', 'i', 'd',
+					},
+				},
+				batches: []cloud.DeploymentLogs{
+					{
+						// sync is disabled at first non-utf8 sequence.
+						{
+							Line:    1,
+							Channel: cloud.StdoutLogChannel,
+							Message: "valid",
+						},
+					},
+				},
+			},
+		},
 	} {
 		tc := tc
 		tc.validate(t)