Fix(create/all-terraform): Add in Name/Description in new stacks. #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for terramate-io-docs canceled.
|
mariux
previously approved these changes
Aug 23, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
=======================================
Coverage 64.57% 64.57%
=======================================
Files 100 100
Lines 15772 15772
=======================================
Hits 10185 10185
Misses 5181 5181
Partials 406 406
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MordecaiMalignatus
force-pushed
the
mm-name-desc-new-stacks
branch
from
18aa98f
to
e90cb0a
Compare
mariux
previously approved these changes
Aug 23, 2023
MordecaiMalignatus
force-pushed
the
mm-name-desc-new-stacks
branch
from
e90cb0a
to
8010435
Compare
|
mariux
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This Change
When we run
terramate create --all-terraform, we do not fill thenameanddescriptionfields. This is different behaviour thanterramate create /path/to/stack, which will usestackas value for both name and description.Description of Changes
When running
terramate create --all-terraform, created stacks now have thesame derived names and descriptions as stacks created without the
--all-terraformflag.