Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tmc): send interpolated command in each drift sync #1152

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Sep 21, 2023

No description provided.

@i4ki i4ki requested a review from a team as a code owner September 21, 2023 08:04
@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for terramate-io-docs canceled.

Name Link
🔨 Latest commit 1a62ac1
🔍 Latest deploy log https://app.netlify.com/sites/terramate-io-docs/deploys/650c35a29d72fb0007427b36

@i4ki i4ki changed the base branch from main to i4k-drift-metadata September 21, 2023 08:04
@i4ki i4ki changed the title feat: send interpolated command in each drift sync feat(tmc): send interpolated command in each drift sync Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (3c25c99) 63.30% compared to head (1a62ac1) 63.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   63.30%   63.27%   -0.04%     
==========================================
  Files         102      102              
  Lines       16188    16193       +5     
==========================================
- Hits        10248    10246       -2     
- Misses       5522     5529       +7     
  Partials      418      418              
Flag Coverage Δ
tests 63.27% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cloud/types.go 38.75% <ø> (ø)
cmd/terramate/cli/cloud.go 0.00% <0.00%> (ø)
cmd/terramate/cli/cloud_sync_deployment.go 0.00% <0.00%> (ø)
cmd/terramate/cli/cloud_sync_drift.go 0.00% <0.00%> (ø)
cmd/terramate/cli/run.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

metric: time/op
ListFiles-2: old 182µs ± 3%: new 182µs ± 2%: delta: 0.00%
Generate-2: old 3.93s ± 2%: new 4.01s ± 3%: delta: 2.02%
GenerateRegex-2: old 2.50s ± 3%: new 2.51s ± 4%: delta: 0.00%
TokensForExpressionComplex-2: old 2.29ms ± 5%: new 2.26ms ± 2%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 1.73µs ± 4%: new 1.73µs ± 3%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 55.4µs ± 3%: new 55.8µs ± 3%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 2.64ms ± 3%: new 2.65ms ± 3%: delta: 0.00%
TokensForExpression-2: old 2.27ms ± 2%: new 2.28ms ± 3%: delta: 0.00%
PartialEvalComplex-2: old 714µs ± 4%: new 714µs ± 2%: delta: 0.00%
PartialEvalSmallString-2: old 6.49µs ± 2%: new 6.46µs ± 3%: delta: 0.00%
PartialEvalHugeString-2: old 3.14ms ± 1%: new 3.14ms ± 3%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 8.51ms ± 2%: new 8.71ms ± 3%: delta: 2.28%
PartialEvalObject-2: old 38.0µs ± 4%: new 38.0µs ± 5%: delta: 0.00%
metric: alloc/op
ListFiles-2: old 99.4kB ± 0%: new 99.4kB ± 0%: delta: 0.00%
Generate-2: old 2.05GB ± 0%: new 2.05GB ± 0%: delta: 0.00%
GenerateRegex-2: old 805MB ± 0%: new 805MB ± 0%: delta: -0.01%
TokensForExpressionComplex-2: old 411kB ± 0%: new 411kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 14.0kB ± 0%: new 14.0kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 400kB ± 0%: new 400kB ± 0%: delta: 0.00%
TokensForExpression-2: old 411kB ± 0%: new 411kB ± 0%: delta: 0.00%
PartialEvalComplex-2: old 344kB ± 0%: new 344kB ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-2: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
metric: allocs/op
ListFiles-2: old 474 ± 0%: new 474 ± 0%: delta: 0.00%
Generate-2: old 22.7M ± 0%: new 22.7M ± 0%: delta: 0.00%
GenerateRegex-2: old 16.4M ± 0%: new 16.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 4.85k ± 0%: new 4.85k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 328 ± 0%: new 328 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-2: old 4.85k ± 0%: new 4.85k ± 0%: delta: 0.00%
PartialEvalComplex-2: old 2.61k ± 0%: new 2.61k ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-2: old 125 ± 0%: new 125 ± 0%: delta: 0.00%

@i4ki i4ki marked this pull request as draft September 21, 2023 11:58
Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>
@i4ki i4ki marked this pull request as ready for review September 21, 2023 12:12
Base automatically changed from i4k-drift-metadata to main September 21, 2023 12:20
@i4ki i4ki dismissed MordecaiMalignatus’s stale review September 21, 2023 12:20

The base branch was changed.

Copy link

@lennyterra lennyterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@i4ki i4ki added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 3a6e6f0 Sep 21, 2023
16 checks passed
@i4ki i4ki deleted the i4k-send-cmd-interpolated branch September 21, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants