Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tmc): add sync of JSON plan with --cloud-sync-terraform-plan-file #1175

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Oct 7, 2023

Reason for This Change

The TMC drift detection feature requires the redacted plan for detecting the drifted resources.

Description of Changes

The --cloud-sync-terraform-plan-file=<file> flag was changed to also synchronize the JSON plan file.

Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>
@i4ki i4ki requested a review from a team as a code owner October 7, 2023 05:31
@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for terramate-io-docs canceled.

Name Link
🔨 Latest commit 35b346e
🔍 Latest deploy log https://app.netlify.com/sites/terramate-io-docs/deploys/65240b18b0edc40008ba344c

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (376be70) 63.03% compared to head (35b346e) 62.88%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
- Coverage   63.03%   62.88%   -0.15%     
==========================================
  Files         102      102              
  Lines       16262    16299      +37     
==========================================
  Hits        10250    10250              
- Misses       5592     5629      +37     
  Partials      420      420              
Flag Coverage Δ
tests 62.88% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/terramate/cli/cloud_sync_drift.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023


@i4ki i4ki added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 34e4b62 Oct 9, 2023
15 checks passed
@i4ki i4ki deleted the i4k-sync-json-plan branch October 9, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants