Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tmc): fail-safe plan file synchronization. #1176

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Oct 11, 2023

When collecting ASCII or JSON plan, errors are logged and skipped. Then now the drift_details field allows the absent of either changeset_ascii or changeset_json but at least one of them must be set.

@i4ki i4ki requested a review from a team as a code owner October 11, 2023 05:37
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for terramate-io-docs canceled.

Name Link
🔨 Latest commit 1fa851d
🔍 Latest deploy log https://app.netlify.com/sites/terramate-io-docs/deploys/6526356183ca7c00086c2a29

When collecting ASCII or JSON plan, errors are logged and skipped.
Then now the `drift_details` field allows the absent of either `changeset_ascii`
or `changeset_json` but at least one of them must be set.

Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (35b346e) 62.88% compared to head (1fa851d) 62.81%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1176      +/-   ##
==========================================
- Coverage   62.88%   62.81%   -0.08%     
==========================================
  Files         102      102              
  Lines       16299    16317      +18     
==========================================
- Hits        10250    10249       -1     
- Misses       5629     5648      +19     
  Partials      420      420              
Flag Coverage Δ
tests 62.81% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/terramate/cli/cloud_sync_drift.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

metric: time/op
ListFiles-2: old 188µs ± 2%: new 164µs ± 4%: delta: -12.47%
Generate-2: old 4.44s ±10%: new 4.44s ± 2%: delta: 0.00%
GenerateRegex-2: old 2.76s ±17%: new 2.69s ± 3%: delta: 0.00%
TokensForExpressionComplex-2: old 1.90ms ±13%: new 1.96ms ± 3%: delta: 2.86%
TokensForExpressionPlainStringNoNewline-2: old 1.40µs ± 3%: new 1.46µs ± 3%: delta: 4.02%
TokensForExpressionStringWith100Newlines-2: old 47.3µs ± 3%: new 48.2µs ± 3%: delta: 1.78%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 2.10ms ± 3%: new 2.14ms ± 4%: delta: 1.96%
TokensForExpression-2: old 1.88ms ± 6%: new 1.91ms ± 3%: delta: 1.65%
PartialEvalComplex-2: old 841µs ± 3%: new 714µs ± 4%: delta: -15.15%
PartialEvalSmallString-2: old 6.62µs ± 3%: new 5.67µs ± 7%: delta: -14.37%
PartialEvalHugeString-2: old 3.38ms ± 4%: new 3.04ms ± 8%: delta: -10.15%
PartialEvalHugeInterpolatedString-2: old 8.35ms ± 3%: new 7.86ms ± 7%: delta: -5.90%
PartialEvalObject-2: old 36.3µs ± 3%: new 33.7µs ± 6%: delta: -7.10%
metric: alloc/op
ListFiles-2: old 99.4kB ± 0%: new 99.4kB ± 0%: delta: -0.01%
Generate-2: old 2.34GB ± 0%: new 2.34GB ± 0%: delta: 0.00%
GenerateRegex-2: old 953MB ± 0%: new 953MB ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 412kB ± 0%: new 412kB ± 0%: delta: 0.01%
TokensForExpressionPlainStringNoNewline-2: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 14.0kB ± 0%: new 14.0kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 402kB ± 0%: new 402kB ± 0%: delta: 0.00%
TokensForExpression-2: old 412kB ± 0%: new 412kB ± 0%: delta: 0.01%
PartialEvalComplex-2: old 353kB ± 0%: new 353kB ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-2: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
metric: allocs/op
ListFiles-2: old 474 ± 0%: new 474 ± 0%: delta: 0.00%
Generate-2: old 25.9M ± 0%: new 25.9M ± 0%: delta: 0.00%
GenerateRegex-2: old 18.3M ± 0%: new 18.3M ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 328 ± 0%: new 328 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 3.29k ± 0%: new 3.29k ± 0%: delta: 0.00%
TokensForExpression-2: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
PartialEvalComplex-2: old 2.83k ± 0%: new 2.83k ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-2: old 125 ± 0%: new 125 ± 0%: delta: 0.00%

@i4ki i4ki added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 8a171f5 Oct 12, 2023
16 checks passed
@i4ki i4ki deleted the i4k-adjust-planfile-sync branch October 12, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants