chore(tmc): use real terraform in e2e tests #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for terramate-io-docs canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
+ Coverage 62.76% 62.82% +0.06%
==========================================
Files 102 102
Lines 16395 16431 +36
==========================================
+ Hits 10290 10323 +33
- Misses 5681 5683 +2
- Partials 424 425 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
i4ki
force-pushed
the
i4k-add-real-terraform-testcases
branch
from
58823c3
to
313ec9c
Compare
i4ki
changed the title
i4ki
force-pushed
the
i4k-add-real-terraform-testcases
branch
from
313ec9c
to
135085a
Compare
|
i4ki
force-pushed
the
i4k-add-real-terraform-testcases
branch
5 times, most recently
from
5cd7968
to
6b9afc7
Compare
i4ki
force-pushed
the
i4k-add-real-terraform-testcases
branch
from
6b9afc7
to
d11e31b
Compare
snakster
previously approved these changes
Oct 16, 2023
## Reasons for this change Before we used a fake terraform binary that mimicked some Terraform behavior and it supported fully customization of the program's output. The problem is that the fake terraform misses a lot of important details: - `terraform show` gives different error messages depending on different requirements not met. - `terraform show` requires an initialized terraform module and then mimicking this behavior is hard. - `terraform show` checks the lock files - etc if we ignore those details, we miss the opportunity to test those cases and improve Terramate error messages for such errors. _The error message improvements are not addressed in this PR_. ## Changes - Now during the e2e test setup, the Terraform is installed in a temp directory using the hashicorp official `hc-install` library. - Tests were updated to use a real project. - Sandbox library updated to support `copy` and `run` commands.
i4ki
force-pushed
the
i4k-add-real-terraform-testcases
branch
from
39180fb
to
3668835
Compare
snakster
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for this change
Before we used a fake terraform binary that mimicked some Terraform behavior and it supported fully customization of the program's output.
The problem is that the fake terraform misses a lot of important details:
terraform showgives different error messages depending on different requirements not met.terraform showrequires an initialized terraform module and then mimicking this behavior is hard.terraform showchecks the lock filesif we ignore those details, we miss the opportunity to test those cases and improve Terramate error messages for such errors.
The error message improvements are not addressed in this PR.
Changes
hc-installlibrary.copyandruncommands.