feat(tmc): send logs of the user-supplied command to Terramate Cloud. #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for terramate-io-docs canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
- Coverage 62.75% 62.62% -0.13%
==========================================
Files 102 103 +1
Lines 16395 16579 +184
==========================================
+ Hits 10288 10383 +95
- Misses 5683 5766 +83
- Partials 424 430 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
i4ki
force-pushed
the
i4k-send-logging
branch
3 times, most recently
from
e7d9879
to
c9312fa
Compare
snakster
reviewed
Oct 17, 2023
snakster
reviewed
Oct 17, 2023
# Reasons for This Change Terramate Cloud supports visualizing the deployment logs in real-time. ## Description of the changes A log syncer was created that proxies stdout/stderr writes using an in-memory pipe. The syncer creates 3 goroutines (1 for stdout, 1 for stderr and 1 for synchronizing logs) that *MUST* be shutdown/terminated after execution of each stack. The syncer supports a customizable `batchSize` and `maxLineSize` but the requirement of the latter will be fixed in a separate PR. Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>
i4ki
force-pushed
the
i4k-send-logging
branch
from
c8ebe9d
to
9e642fe
Compare
snakster
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for This Change
Terramate Cloud supports visualizing the deployment logs in real-time.
Description of the changes
A log syncer was created that proxies stdout/stderr writes using an in-memory pipe. The syncer creates 3 goroutines (1 for stdout, 1 for stderr and 1 for synchronizing logs) that MUST be shutdown/terminated after execution of each stack.
The syncer supports a customizable
batchSizeandmaxLineSizebut the requirement of the latter will be fixed in a separate PR.