fix(tmc): panic due to index out of range in logsyncer #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Reasons For This Change
When providing an stdout/stderr containing an empty line,
the log syncer crashes:
```
panic: runtime error: index out of range [-1]
goroutine 213 [running]:
github.com/terramate-io/terramate/cloud.dropCRLN(...)
/vagrant/terramate/cloud/log_syncer.go:192
github.com/terramate-io/terramate/cloud.(*LogSyncer).NewBuffer.func1()
/vagrant/terramate/cloud/log_syncer.go:103 +0x6fd
created by github.com/terramate-io/terramate/cloud.(*LogSyncer).NewBuffer
/vagrant/terramate/cloud/log_syncer.go:80 +0x2a5
FAIL github.com/terramate-io/terramate/cloud 0.055s
FAIL
```
### Description of Changes
A bounds check is added before removing the CRLN from the line.
Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>
✅ Deploy Preview for terramate-io-docs canceled.
|
i4ki
changed the title
i4ki
changed the title
|
snakster
reviewed
Oct 20, 2023
snakster
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons For This Change
When providing an stdout/stderr containing an empty line, the log syncer crashes:
Description of Changes
A bounds check is added before removing the CRLN from the line.