Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate condition on generate #372

Merged
merged 32 commits into from
Jun 3, 2022
Merged

feat: integrate condition on generate #372

merged 32 commits into from
Jun 3, 2022

Conversation

katcipis
Copy link
Contributor

@katcipis katcipis commented Jun 1, 2022 •
edited

This PR introduces the condition functionality specified here and here.

@katcipis
test: add condition to tests + prototype
7a1dd7f
@katcipis
feat: add initial conditional handling on generate_file
dc06b94
@katcipis
feat: add error handling for condition eval
2702b19
@katcipis
feat: add condition type check
36c4c7d
@katcipis
test: add condition on genhcl tests
b814a71
@katcipis
test: add tests for genhcl condition
7033a13
@katcipis
refactor: move parsing logic to hcl parser func
f614ce9
@katcipis
feat: add condition to genhcl
7ec30f3
@katcipis
Merge branch 'main' of github.com:mineiros-io/terramate into katcipis…
c3de85e 
…-generate-conditionals
@katcipis
Merge branch 'main' of github.com:mineiros-io/terramate into katcipis…
9ac02f8 
…-generate-conditionals
@katcipis
refactor: rename genfile type
2fc52f3
@katcipis
test: add initial test for condition attr
e3282a1
@katcipis
refactor: rename hcl building functions back
8c2da25
@katcipis
feat: remove files with condition = false
253299d
@katcipis
Merge branch 'main' of github.com:mineiros-io/terramate into katcipis…
3b82038 
…-integrate-condition-on-generate
@katcipis
test: add test for condition + deleting files
3f150d8
@katcipis
test: add generate_file condition outdated detection test
6220130
@katcipis
test: add gen hcl check outdated test
3bd88b4
@katcipis
feat: oudated detect genhcl with condition properly
7d9b438
@katcipis
feat: properly detect changes using condition
7d293aa
@katcipis
test: add test to delete generate_file with condition=false
6a5b848
@katcipis
Merge branch 'main' of github.com:mineiros-io/terramate into katcipis…
8901edd 
…-integrate-condition-on-generate
@katcipis
refactor: avoid filtering code with false condition
41381ea
@katcipis
test: ensure that files are deleted on generate_file
5854974
@katcipis
refactor: improve tests
51706c1
@katcipis katcipis self-assigned this Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022 •
edited

Codecov Report

Merging #372 (15b7bb7) into main (6a76141) will decrease coverage by 0.15%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   69.49%   69.34%   -0.16%     
==========================================
  Files          37       37              
  Lines        7317     7281      -36     
==========================================
- Hits         5085     5049      -36     
  Misses       1975     1975              
  Partials      257      257
Flag Coverage Δ
tests 69.34% <76.19%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
generate/generate.go 78.66% <76.19%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a76141...15b7bb7. Read the comment docs.

@katcipis katcipis requested a review from i4ki June 2, 2022 18:32
@katcipis katcipis marked this pull request as ready for review June 2, 2022 18:32
i4ki
i4ki reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@i4ki i4ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review

will checkout the branch and play a bit tomorrow.

generate/generate.go Outdated Show resolved Hide resolved
generate/generate.go Outdated Show resolved Hide resolved
generate/generate.go Outdated Show resolved Hide resolved
katcipis and others added 4 commits June 3, 2022 11:45
@katcipis katcipis requested a review from i4ki June 3, 2022 09:51
i4ki
i4ki approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@i4ki i4ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katcipis katcipis merged commit aaebe3b into main Jun 3, 2022
@katcipis katcipis deleted the katcipis-integrate-condition-on-generate branch June 3, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i4ki i4ki i4ki approved these changes

Assignees

@katcipis katcipis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katcipis @i4ki