-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: partial eval misusing Token.Bytes slice #379
Conversation
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 69.30% 69.34% +0.04%
==========================================
Files 37 37
Lines 7300 7318 +18
==========================================
+ Hits 5059 5075 +16
- Misses 1981 1982 +1
- Partials 260 261 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + some small considerations if we should test stack path related things on the genhcl package, but not sure about it, feel free to disregard.
The code modified the
*hclwrite.Token.Bytes
slice directly but it seems that multiple Hashicorp tokens can have its bytes backed by the same byte array, so appending bytes totok.Bytes
was overwriting the byte slice of other tokens.Closes #376