feat: move stack metadata related to terramate.stack #380
Conversation
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 69.34% 69.30% -0.05%
==========================================
Files 37 37
Lines 7281 7300 +19
==========================================
+ Hits 5049 5059 +10
- Misses 1975 1981 +6
- Partials 257 260 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| ctyObject := cty.Object(ctyTypes) | ||
| ctyVal, err := gocty.ToCtyValue(m, ctyObject) | ||
| ctyVal, err := gocty.ToCtyValue(values, ctyObject) |
There was a problem hiding this comment.
I'm torn if we shouldn't just panic here. The conversion always uses terramate evaluated things (or built by ourselves some other way), so feels like a bug/critical thing going on that could be panicked (would simplify a lot the error handling around this). WDYT @i4ki ?
There was a problem hiding this comment.
I think makes sense, as this a controlled namespace.
There was a problem hiding this comment.
Will improve this on a follow up PR.
…-move-metadata-stack
katcipis
changed the title
Moving stack metadata to "terramate.stack". The old metadata is being kept for now to avoid breaking anything. New metadata:
New metadata will be added on a future PR.