-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: conflict detection only for generated files #393
Conversation
…conflict-detection
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 69.57% 69.65% +0.07%
==========================================
Files 37 37
Lines 7314 7276 -38
==========================================
- Hits 5089 5068 -21
+ Misses 1971 1958 -13
+ Partials 254 250 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…conflict-detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + some small possible improvements. Regarding sorting it can also be ignored or assessed later in a different PR. Thanks for fixing this 🚀
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
…erramate into i4k-fix-conflict-detection
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
Closes #390